martinzink commented on code in PR #1314:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1314#discussion_r857406565
##########
libminifi/src/sitetosite/RawSocketProtocol.cpp:
##########
@@ -240,6 +240,12 @@ bool
RawSiteToSiteClient::initiateCodecResourceNegotiation() {
}
}
+namespace {
+void logPortStateError(std::shared_ptr<core::logging::Logger>& logger,
utils::Identifier port_id, const std::string& error) {
Review Comment:
I trust the compiler and since its slightly more readable I've changed it
(thanks for the suggestion) :+1:
https://github.com/apache/nifi-minifi-cpp/pull/1314/commits/deb192a736ab05fc942379c959d97a6657d9aae0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
