szaszm commented on code in PR #1299:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1299#discussion_r858832450
##########
libminifi/include/core/state/Value.h:
##########
@@ -497,34 +495,31 @@ static inline std::shared_ptr<Value> createValue(const
double &object) {
* Purpose: ValueNode is the AST container for a value
*/
class ValueNode {
- public:
- ValueNode()
- : value_(nullptr) {
- }
+ using supported_types = utils::meta::type_list<int, uint32_t, size_t,
int64_t, uint64_t, bool, char*, const char*, double, std::string>;
+ public:
+ ValueNode() = default;
ValueNode(ValueNode &&vn) = default;
ValueNode(const ValueNode &vn) = default;
+ ValueNode &operator=(const ValueNode &ref) = default;
Review Comment:
An oversight, will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
