szaszm commented on code in PR #1299:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1299#discussion_r859761340
##########
libminifi/src/c2/C2Client.cpp:
##########
@@ -68,7 +71,23 @@ void
C2Client::initialize(core::controller::ControllerServiceProvider *controlle
logger_->log_info("Agent class is not predefined");
}
- configuration_->setFallbackAgentIdentifier(getControllerUUID().to_string());
+ // Set a persistent fallback agent id. This is needed so that the C2 server
can identify the same agent after a restart, even if nifi.c2.agent.identifier
is not specified.
Review Comment:
I found it complicated to change the identifier/fallback identifier logic,
but I can introduce a new property called nifi.c2.agent.identifier.fallback,
and write to that. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
