lordgamez commented on code in PR #1330:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1330#discussion_r872129172
##########
libminifi/src/controllers/SSLContextService.cpp:
##########
@@ -213,7 +213,8 @@ bool
SSLContextService::addP12CertificateToSSLContext(SSL_CTX* ctx) const {
core::logging::LOG_ERROR(logger_) << "Failed to set additional
certificate from " << certificate_ << ", " << getLatestOpenSSLErrorString();
return false;
}
- cacert.release(); // a successful SSL_CTX_add_extra_chain_cert() takes
ownership of cacert
+ // a successful SSL_CTX_add_extra_chain_cert() takes ownership of cacert
+ cacert.release(); // NOLINT(bugprone-unused-return-value)
Review Comment:
Good idea, updated in 3b4102f32349a842f90c11b08189d9e79411eca3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
