szaszm commented on code in PR #1330:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1330#discussion_r872588577
##########
extensions/procfs/CpuStat.h:
##########
@@ -34,7 +34,12 @@ class CpuStatData {
public:
static std::optional<CpuStatData> parseCpuStatLine(std::istream& iss);
- auto operator<=>(const CpuStatData& rhs) const = default;
+ bool operator<=(const CpuStatData& rhs) const;
+ bool operator>(const CpuStatData& rhs) const;
+ bool operator>=(const CpuStatData& rhs) const;
+ bool operator<(const CpuStatData& rhs) const;
+ bool operator==(const CpuStatData& rhs) const;
+ bool operator!=(const CpuStatData& rhs) const;
Review Comment:
This is a clang (or rather libc++) bug. I would rather have one manual
spaceship operator implementation that lexicographically compares each member
instead of writing all six manually, without any kind of strict ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
