bejancsaba commented on PR #6075: URL: https://github.com/apache/nifi/pull/6075#issuecomment-1157415064
> I have finished my functional review of the c2 client capability added in this PR, and found it to be working as expected. Really awesome to see it in action, it performed wonderfully. Nice work all! > > I only have one observation, which is that heartbeats are being logged at the info level by the OkHttpClient library being used: > > ``` > 2022-06-15 19:10:06,666 INFO [pool-23-thread-1] okhttp3.OkHttpClient --> POST http://host:port/contextPath/heartbeat (875608-byte body) > 2022-06-15 19:10:09,047 INFO [pool-23-thread-1] okhttp3.OkHttpClient <-- 200 OK http://host:port/contextPath/heartbeat (2380ms, 2-byte body) > ``` > > I feel that this is too noisy, and should be moved to the debug level. Perhaps error code responses should be an elevated level (if they are not already). Moved it to debug level, we have dedicated logging for covering errors in most cases. If that is ok from your side we will enhance that as needed in a follow up PR focusing more on testing and potential refactors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
