lordgamez commented on code in PR #1340:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1340#discussion_r908121606
##########
libminifi/src/FlowController.cpp:
##########
@@ -150,6 +154,7 @@ bool FlowController::applyConfiguration(const std::string
&source, const std::st
this->root_ = std::move(prevRoot);
Review Comment:
I think in theory you are right, it could be unlocked if the exception
happens after the unlock. Although the exception check is mostly meant for the
loading of the new configuration, because after the unlock we only write some
logs and set a few configuration values that shouldn't really throw any
exceptions. Just in case I added the additional lock in
61844c0a17630875f7db41fcd329bedae7ef9df6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
