lordgamez commented on code in PR #1340:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1340#discussion_r908140314
##########
libminifi/src/FlowController.cpp:
##########
@@ -150,6 +154,7 @@ bool FlowController::applyConfiguration(const std::string
&source, const std::st
this->root_ = std::move(prevRoot);
Review Comment:
As far as I remember it could cause a deadlock when the updating_ flag is
checked from another thread and it's already set to false trying to acquire the
lock afterwards, but it's still locked, so we have to unlock it before setting
the update_ flag back to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
