markobean commented on PR #6151: URL: https://github.com/apache/nifi/pull/6151#issuecomment-1172541808
I found some interesting things while testing this PR. When using ReplaceText in a flow, I found a buffer size < 8k never caused the BufferOverflowException. I believe this is due to a hard-coded default initial size of the buffer in StreamCallback (ReplaceText:747). While 8k seems a reasonable limit, I think it would be more accurate to use `Math.min(maxBufferSize, 8192)`. Otherwise, ReplaceText will not fail FlowFiles with lines larger than the buffer size (and less than 8 KB). I can imagine some users may want to use the failure relationship to identify lines longer than X bytes/characters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
