markobean commented on PR #6151: URL: https://github.com/apache/nifi/pull/6151#issuecomment-1192651015
@NissimShiman Thanks for addressing the comments. I agree that any remaining issues, e.g. 8k hardcoded buffer, represent scope creep and do not need to be addressed in this PR. As for the intent of NIFI-10154, I think we're now in good shape. I tested by doing a full build, installing/running NiFi. I configured ReplaceText with a buffer of "4 b". The input flowfile had 3 lines: 3 bytes, 100 bytes, 4 bytes. The flowfile did not stay in the input queue withy an admin yield. Instead, it went to failure with a bulletin indicating: ReplaceText[id=ba5a1eb4-0181-1000-df09-07adb5e22f46] Transferred FlowFile[filename=f7a9e492-5527-410f-9195-a2af89f68a56] to 'failure' due to java.nio.BufferOverflowException Works as designed. Thanks for the update. We just need a final review from a committer. +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
