szaszm commented on code in PR #1369:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1369#discussion_r921862093
##########
docker/DockerVerify.sh:
##########
@@ -67,11 +67,11 @@ TEST_DIRECTORY="${docker_dir}/test/integration"
export TEST_DIRECTORY
# Add --no-logcapture to see logs interleaved with the test output
-BEHAVE_OPTS=(-f pretty --logging-level INFO --logging-clear-handlers --tags
~@no-ci)
Review Comment:
My point is that there would be no harm in keeping the tag, even if unused.
The added complexity is minimal, and there may be cases in the future where we
need to disable individual (e.g. long running) tests, not the whole extension.
It can also be readded, so it's fine if you prefer to still remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
