martinzink commented on code in PR #1369: URL: https://github.com/apache/nifi-minifi-cpp/pull/1369#discussion_r923142594
########## docker/bionic/Dockerfile: ########## @@ -20,6 +20,8 @@ FROM ubuntu:bionic AS build_deps LABEL maintainer="Apache NiFi <[email protected]>" +# MINIFI_OPTIONS will be passed directly to cmake +# use it to define cmake options (e.g. -DENABLE_AWS=ON -DENABLE_AZURE=ON) Review Comment: you are absolutely right :+1: fixed in https://github.com/apache/nifi-minifi-cpp/pull/1369/commits/6851250bc6ce26b4c7a0c5824e66cf8d7d16f923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
