szaszm commented on code in PR #1372:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1372#discussion_r923313715
##########
CMakeLists.txt:
##########
@@ -68,8 +68,8 @@ option(USE_REAL_ODBC_TEST_DRIVER "Use SQLite ODBC driver in
SQL extenstion unit
# different than "GNU Makefiles".
option (FORCE_COLORED_OUTPUT "Always produce ANSI-colored output (GNU/Clang
only)." FALSE)
option(AWS_ENABLE_UNITY_BUILD "If enabled, AWS SDK libraries will be built as
a single, generated .cpp file. \
- This can significantly reduce static library size as well as speed up a
single compilation time, but it is regenerated \
- and recompiled in every iterative build instance. Turn off to avoid
recompilation." ON)
+ This can significantly reduce static library size as well as speed up a
single compilation time, but it is regenerated \
+ and recompiled in every iterative build instance. Turn off to avoid
recompilation." ON)
Review Comment:
Continuations should be indented with two extra levels of indentation.
##########
cmake/BundledRocksDB.cmake:
##########
@@ -42,9 +42,9 @@ function(use_bundled_rocksdb SOURCE_DIR BINARY_DIR)
if(PORTABLE)
list(APPEND ROCKSDB_CMAKE_ARGS -DPORTABLE=ON)
endif()
- if(WIN32)
- list(APPEND ROCKSDB_CMAKE_ARGS -DROCKSDB_INSTALL_ON_WINDOWS=ON)
- endif()
+ if(WIN32)
Review Comment:
This is messed up, too. I'm assuming your tool only replaced tabs with 2
spaces, but not existing 4 space indentation with 2 spaces.
##########
cmake/BundledLibArchive.cmake:
##########
@@ -116,5 +116,5 @@ function(use_bundled_libarchive SOURCE_DIR BINARY_DIR)
endif()
file(MAKE_DIRECTORY ${LIBARCHIVE_INCLUDE_DIRS})
set_property(TARGET LibArchive::LibArchive APPEND PROPERTY
INTERFACE_INCLUDE_DIRECTORIES ${LIBARCHIVE_INCLUDE_DIRS})
- set_property(TARGET LibArchive::LibArchive APPEND PROPERTY
INTERFACE_COMPILE_DEFINITIONS "LIBARCHIVE_STATIC=1")
+ set_property(TARGET LibArchive::LibArchive APPEND PROPERTY
INTERFACE_COMPILE_DEFINITIONS "LIBARCHIVE_STATIC=1")
Review Comment:
This looks messed up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
