szaszm commented on code in PR #1372:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1372#discussion_r923462069
##########
CMakeLists.txt:
##########
@@ -562,22 +562,22 @@ set(CPACK_COMPONENTS_GROUPING "ALL_COMPONENTS_IN_ONE")
list(APPEND CPACK_COMPONENTS_ALL bin)
cpack_add_component(bin DISPLAY_NAME "MiNiFi C++ executables" REQUIRED)
if(NOT WIN32)
- list(APPEND CPACK_COMPONENTS_ALL conf)
- cpack_add_component(conf DISPLAY_NAME "Default configuration files"
REQUIRED)
+ list(APPEND CPACK_COMPONENTS_ALL conf)
+ cpack_add_component(conf DISPLAY_NAME "Default configuration files"
REQUIRED)
endif()
cpack_add_component_group(extensions DISPLAY_NAME "Extensions" EXPANDED)
foreach(extension ${selected_extensions})
- get_component_name(${extension} component-name)
- list(APPEND CPACK_COMPONENTS_ALL ${component-name})
- cpack_add_component(${component-name} DISPLAY_NAME ${extension} GROUP
extensions DEPENDS bin)
+ get_component_name(${extension} component-name)
+ list(APPEND CPACK_COMPONENTS_ALL ${component-name})
+ cpack_add_component(${component-name} DISPLAY_NAME ${extension} GROUP
extensions DEPENDS bin)
endforeach()
include(CPack)
### include modules
if (NOT SKIP_TESTS)
- include(BuildTests)
+ include(BuildTests)
Review Comment:
only 2 spaces here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]