fgerlits commented on code in PR #1362:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1362#discussion_r924428505
##########
extensions/standard-processors/processors/GetFile.cpp:
##########
@@ -244,7 +244,7 @@ bool GetFile::fileMatchesRequestCriteria(std::string
fullName, std::string name,
return false;
utils::Regex rgx(request.fileFilter);
- if (!utils::regexSearch(name, rgx)) {
Review Comment:
I see, NiFi has `"[^\\.].*"` as the default for `FileFilter`, as well. It's
not ideal to have to change two properties if I want to include hidden files
(also I don't think the `\` in the regex is necessary), but I agree that having
the same default as NiFi is a good thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
