lordgamez commented on code in PR #1362:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1362#discussion_r924439206
##########
extensions/standard-processors/processors/GetFile.cpp:
##########
@@ -244,7 +244,7 @@ bool GetFile::fileMatchesRequestCriteria(std::string
fullName, std::string name,
return false;
utils::Regex rgx(request.fileFilter);
- if (!utils::regexSearch(name, rgx)) {
Review Comment:
I don't know how closely we want to stay with the NiFi implementation, but I
agree it would be better to have `.*` as the default. I'm okay with both, I
wonder what the others think about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
