exceptionfactory commented on code in PR #6225:
URL: https://github.com/apache/nifi/pull/6225#discussion_r941319081
##########
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java:
##########
@@ -199,7 +199,7 @@ public abstract class AbstractMQTTProcessor extends
AbstractSessionFactoryProces
.build();
public static final PropertyDescriptor PROP_SESSION_EXPIRY_INTERVAL = new
PropertyDescriptor.Builder()
- .name("Session Expiry Interval")
+ .name("Session Expiry Interval (seconds)")
Review Comment:
Changing the property name breaks backward compatibility, so this change
needs to be reverted. It is possible to change the `displayName`, but in this
case, I think it is better to rely on the description instead of adding hint to
the property name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
