exceptionfactory commented on code in PR #6225:
URL: https://github.com/apache/nifi/pull/6225#discussion_r941321632


##########
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java:
##########
@@ -199,7 +199,7 @@ public abstract class AbstractMQTTProcessor extends 
AbstractSessionFactoryProces
             .build();
 
     public static final PropertyDescriptor PROP_SESSION_EXPIRY_INTERVAL = new 
PropertyDescriptor.Builder()
-            .name("Session Expiry Interval")
+            .name("Session Expiry Interval (seconds)")

Review Comment:
   Reading more closely, I see this is a new property, so disregard the 
previous comment. Even though the unit of measure is different, I tend to agree 
with @tpalfy that using the Time Unit Validator is better for this new property.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to