Github user devriesb commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87807081
--- Diff:
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/BufferedInputStream.java
---
@@ -16,19 +16,445 @@
*/
package org.apache.nifi.stream.io;
+import java.io.IOException;
import java.io.InputStream;
/**
* This class is a slight modification of the BufferedInputStream in the
java.io package. The modification is that this implementation does not provide
synchronization on method calls, which means
* that this class is not suitable for use by multiple threads. However,
the absence of these synchronized blocks results in potentially much better
performance.
*/
-public class BufferedInputStream extends java.io.BufferedInputStream {
+public class BufferedInputStream extends InputStream {
--- End diff --
I agree with Joe... we've had instance where eclipse (and I assume IntelliJ
/ other IDEs) suggest the nifi version of BufferedInputStream, resulting in
bad, unexpected behavior. The name is really unfortunate. Perhaps move the
functionality to "UnsycnchronizedBufferedInputStream", modify nifi's
BufferedInputStream to be an empty extension, and deprecate it. Then complete
the rename / remove in a future release (like a major version bump, if the
breaking change is the concern...).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
