Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87808270
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/TestPersistentProvenanceRepository.java
---
@@ -1914,112 +1916,6 @@ public void
testFailureToCreateWriterDoesNotPreventSubsequentRollover() throws I
}
- @Test
- public void testBehaviorOnOutOfMemory() throws IOException,
InterruptedException {
--- End diff --
This test was assuming that the Record Writer was the SimpleRecordWriter
and really made some other assumptions that it shouldn't make. It wasn't a
well-written unit test, in general, as it was assuming dependencies between
classes, so was really more of an integration test. I considered refactoring to
make it work but then decided to simply remove it, since we already have a JIRA
anyway for fixing how NiFi handles OOME by letting the process die and having
the bootstrap restart it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
