martinzink commented on code in PR #1383:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1383#discussion_r954889736
##########
extensions/script/ExecuteScript.h:
##########
@@ -185,23 +124,11 @@ class ExecuteScript : public core::Processor {
ScriptEngineFactory engine_factory_;
#ifdef LUA_SUPPORT
- std::unique_ptr<ScriptEngineQueue<lua::LuaScriptEngine>> script_engine_q_;
+ std::shared_ptr<utils::ResourceQueue<lua::LuaScriptEngine>>
lua_script_engine_queue_;
Review Comment:
The utils::ResourceQueue must be a shared_ptr because the ResourceWrappers
have weak_ptrs in them so they can return the resource (if the queue is still
available).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
