martinzink commented on code in PR #1383:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1383#discussion_r954895207
##########
extensions/http-curl/client/HTTPClient.h:
##########
@@ -81,103 +83,72 @@ class HTTPClient : public BaseHTTPClient, public
core::Connectable {
static int debug_callback(CURL *handle, curl_infotype type, char *data,
size_t size, void *userptr);
- void setVerbose(bool use_stderr = false) override;
+ void setVerbose(bool use_stderr) override;
- void addFormPart(const std::string& content_type, const std::string& name,
HTTPUploadCallback* read_callback, const std::optional<std::string>& filename =
std::nullopt);
+ void addFormPart(const std::string& content_type, const std::string& name,
std::unique_ptr<utils::HTTPUploadCallback> form_callback, const
std::optional<std::string>& filename);
void forceClose();
- void initialize(const std::string &method, const std::string url = "", const
std::shared_ptr<minifi::controllers::SSLContextService> ssl_context_service =
nullptr) override;
-
- // This is a bad API and deprecated. Use the std::chrono variant of this
- // It is assumed that the value of timeout provided to this function
- // is in seconds units
- DEPRECATED(/*deprecated in*/ 0.8.0, /*will remove in */ 2.0) void
setConnectionTimeout(int64_t timeout) override;
-
- // This is a bad API and deprecated. Use the std::chrono variant of this
- // It is assumed that the value of timeout provided to this function
- // is in seconds units
- DEPRECATED(/*deprecated in*/ 0.8.0, /*will remove in */ 2.0) void
setReadTimeout(int64_t timeout) override;
+ void initialize(std::string method, std::string url,
std::shared_ptr<minifi::controllers::SSLContextService> ssl_context_service)
override;
void setConnectionTimeout(std::chrono::milliseconds timeout) override;
void setReadTimeout(std::chrono::milliseconds timeout) override;
- void setUploadCallback(HTTPUploadCallback *callbackObj) override;
+ void setUploadCallback(std::unique_ptr<utils::HTTPUploadCallback> callback)
override;
- void setSeekFunction(HTTPUploadCallback *callbackObj) override;
+ virtual void setReadCallback(std::unique_ptr<utils::HTTPReadCallback>
callback);
Review Comment:
absolutely not, removed the virtual keyword in
https://github.com/apache/nifi-minifi-cpp/pull/1383/commits/044ce269808a28e5a6eaeca34fb30747426a6ab7#diff-475912c726caf957fa46ce1b55d3e845e89aa19b4c7caf2cd4a0ae1f860cbdd5L100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
