markap14 commented on code in PR #6433: URL: https://github.com/apache/nifi/pull/6433#discussion_r975578025
########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/registry/StandardFlowRegistryClientNode.java: ########## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.controller.registry; + +import org.apache.nifi.annotation.behavior.Restricted; +import org.apache.nifi.annotation.documentation.DeprecationNotice; +import org.apache.nifi.authorization.Resource; +import org.apache.nifi.authorization.resource.Authorizable; +import org.apache.nifi.authorization.resource.ResourceFactory; +import org.apache.nifi.authorization.resource.ResourceType; +import org.apache.nifi.bundle.BundleCoordinate; +import org.apache.nifi.components.ConfigurableComponent; +import org.apache.nifi.components.ValidationResult; +import org.apache.nifi.components.validation.ValidationStatus; +import org.apache.nifi.components.validation.ValidationTrigger; +import org.apache.nifi.controller.AbstractComponentNode; +import org.apache.nifi.controller.FlowController; +import org.apache.nifi.controller.LoggableComponent; +import org.apache.nifi.controller.ReloadComponent; +import org.apache.nifi.controller.TerminationAwareLogger; +import org.apache.nifi.controller.ValidationContextFactory; +import org.apache.nifi.controller.flow.FlowManager; +import org.apache.nifi.controller.service.ControllerServiceProvider; +import org.apache.nifi.flow.ExternalControllerServiceReference; +import org.apache.nifi.flow.ParameterProviderReference; +import org.apache.nifi.flow.VersionedFlowCoordinates; +import org.apache.nifi.flow.VersionedParameterContext; +import org.apache.nifi.flow.VersionedProcessGroup; +import org.apache.nifi.nar.ExtensionManager; +import org.apache.nifi.nar.NarCloseable; +import org.apache.nifi.parameter.ParameterContext; +import org.apache.nifi.parameter.ParameterLookup; +import org.apache.nifi.registry.ComponentVariableRegistry; +import org.apache.nifi.registry.flow.FlowRegistryBucket; +import org.apache.nifi.registry.flow.FlowRegistryClient; +import org.apache.nifi.registry.flow.FlowRegistryClientConfigurationContext; +import org.apache.nifi.registry.flow.FlowRegistryClientNode; +import org.apache.nifi.registry.flow.FlowRegistryClientUserContext; +import org.apache.nifi.registry.flow.FlowRegistryException; +import org.apache.nifi.registry.flow.FlowRegistryInvalidException; +import org.apache.nifi.registry.flow.FlowRegistryUtil; +import org.apache.nifi.registry.flow.RegisteredFlow; +import org.apache.nifi.registry.flow.RegisteredFlowSnapshot; +import org.apache.nifi.registry.flow.RegisteredFlowSnapshotMetadata; +import org.apache.nifi.registry.flow.SimpleRegisteredFlowSnapshot; +import org.apache.nifi.registry.flow.SimpleRegisteredFlowSnapshotMetadata; +import org.apache.nifi.util.CharacterFilterUtils; +import org.apache.nifi.util.file.classloader.ClassLoaderUtils; + +import java.io.IOException; +import java.net.URL; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +public final class StandardFlowRegistryClientNode extends AbstractComponentNode implements FlowRegistryClientNode { + + private final FlowController flowController; + private final LoggableComponent<FlowRegistryClient> client; + private volatile String description; + + public StandardFlowRegistryClientNode( + final FlowController flowController, + final LoggableComponent<FlowRegistryClient> client, + final String id, + final ValidationContextFactory validationContextFactory, + final ControllerServiceProvider serviceProvider, + final String componentType, + final String componentCanonicalClass, + final ComponentVariableRegistry variableRegistry, + final ReloadComponent reloadComponent, + final ExtensionManager extensionManager, + final ValidationTrigger validationTrigger, + final boolean isExtensionMissing) { + super(id, validationContextFactory, serviceProvider, componentType, componentCanonicalClass, variableRegistry, reloadComponent, extensionManager, validationTrigger, isExtensionMissing); + this.flowController = flowController; + this.client = client; + } + + @Override + public Authorizable getParentAuthorizable() { + return flowController; + } + + @Override + public Resource getResource() { + return ResourceFactory.getComponentResource(ResourceType.Controller, getIdentifier(), getName()); + } + + @Override + public String getProcessGroupIdentifier() { + return null; + } + + @Override + protected List<ValidationResult> validateConfig() { + return Collections.emptyList(); + } + + @Override + public void verifyModifiable() throws IllegalStateException { + // FlowRegistryClients has no running state + } + + @Override + public void setProperties(final Map<String, String> properties, final boolean allowRemovalOfRequiredProperties, final Set<String> updatedSensitiveDynamicPropertyNames) { + super.setProperties(properties, allowRemovalOfRequiredProperties, updatedSensitiveDynamicPropertyNames); + } Review Comment: Any reason we're overriding this method just to call super? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
