markap14 commented on PR #6433: URL: https://github.com/apache/nifi/pull/6433#issuecomment-1252636917
Thanks for putting up the Draft PR @simonbence This is definitely a HUGE PR. I think a lot of it stems from the fact that there were some class name changes (VersionedFlowSnapshot -> RegisteredFlowSnapshot, for example). This clarifies things because it avoids naming conflicts. Perhaps the rename itself that should have been pushed up as a separate PR, but not a big deal. Putting up the Draft PR, though, is really helpful, I think, because it will allow us to move much more quickly when all is finished up because we've had a good chance to review the approach Overall, I think you're very much on the right track, too! I did make a few comments inline. Overall, though, I think this is definitely heading in the right direction. All of the GitHub actions failed and there are a few TODO's. So I know it's still a work in progress, but this is really good. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
