sardell opened a new pull request, #6437: URL: https://github.com/apache/nifi/pull/6437
This PR contains UI changes around Add/Edit Registry dialogs as a result of changes in https://github.com/apache/nifi/pull/6433. A quick summary of the work in this PR: * Previously, we utilized one dialog for both adding and editing a registry. Because we need to support adding/editing/deleting properties, the two dialogs have much less in common now. I've separated the dialogs into two distinct .jsp files. * I removed the url input in the Add Registry dialog and added a combo dropdown for class type selection. * I added tabs to the Edit Registry dialog. One of these tabs contains a table for adding/editing properties. I'm currently waiting to see if #6433 will support dynamic properties. If it doesn't, I'll need to update this work to conditionally show/hide the add property button. It currently does not work in this PR. * This PR contains all the changes from #6433. I'm unable to start NiFi with latest work on that branch due to some java errors, which @simonbence is aware of. I'm going to open this PR as a draft until that's resolved. # Summary [NIFI-10497](https://issues.apache.org/jira/browse/NIFI-10497) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
