mcgilman commented on code in PR #6437:
URL: https://github.com/apache/nifi/pull/6437#discussion_r980008876
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-service.js:
##########
@@ -670,6 +702,44 @@
var providerItem =
$('<li></li>').append(providerState).append(providerBulletins).append(parameterProviderLink).append(providerType);
providers.append(providerItem);
+ } else if (referencingComponent.referenceType ===
'FlowRegistryClient') {
+ var registryLink = $('<span
class="referencing-component-name
link"></span>').text(referencingComponent.name).on('click', function () {
+ var registryGrid =
$('#registries-table').data('gridInstance');
+ var registryData = registryGrid.getData();
+
+ // select the selected row
+ var row =
registryData.getRowById(referencingComponent.id);
+ registryGrid.setSelectedRows([row]);
+ registryGrid.scrollRowIntoView(row);
+
+ // select the reporting task tab
+ $('#settings-tabs').find('li:nth-child(4)').click();
+
+ // close the dialog and shell
+ referenceContainer.closest('.dialog').modal('hide');
+ });
+
+ // registry state - used to show the validation errors
+ var registryState = $('<div
class="referencing-component-state
invalid"></div>').addClass(referencingComponent.id + 'state');
+
+ if
(nfCommon.isEmpty(referencingComponent.validationErrors)) {
+ registryState.hide();
+ } else {
+ updateValidationErrors(registryState,
referencingComponent);
+ }
+
+ // type
+ var registryType = $('<span
class="referencing-component-type"></span>').text(nfCommon.substringAfterLast(referencingComponent.type,
'.'));
+
+ // active thread count
+ var registryActiveThreadCount = $('<span
class="referencing-component-active-thread-count"></span>').addClass(referencingComponent.id
+ '-active-threads');
+ if
(nfCommon.isDefinedAndNotNull(referencingComponent.activeThreadCount) &&
referencingComponent.activeThreadCount > 0) {
+ registryActiveThreadCount.text('(' +
referencingComponent.activeThreadCount + ')');
+ }
+
+ // registry item
+ var registryItem =
$('<li></li>').append(registryState).append(registryLink).append(registryType).append(registryActiveThreadCount);
+ tasks.append(registryItem);
Review Comment:
These registry clients are being added to the Reporting Tasks section.
Please create a dedicated section to Flow Registry Clients.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-service.js:
##########
@@ -670,6 +702,44 @@
var providerItem =
$('<li></li>').append(providerState).append(providerBulletins).append(parameterProviderLink).append(providerType);
providers.append(providerItem);
+ } else if (referencingComponent.referenceType ===
'FlowRegistryClient') {
+ var registryLink = $('<span
class="referencing-component-name
link"></span>').text(referencingComponent.name).on('click', function () {
+ var registryGrid =
$('#registries-table').data('gridInstance');
+ var registryData = registryGrid.getData();
+
+ // select the selected row
+ var row =
registryData.getRowById(referencingComponent.id);
+ registryGrid.setSelectedRows([row]);
+ registryGrid.scrollRowIntoView(row);
+
+ // select the reporting task tab
+ $('#settings-tabs').find('li:nth-child(4)').click();
+
+ // close the dialog and shell
+ referenceContainer.closest('.dialog').modal('hide');
+ });
+
+ // registry state - used to show the validation errors
+ var registryState = $('<div
class="referencing-component-state
invalid"></div>').addClass(referencingComponent.id + 'state');
+
+ if
(nfCommon.isEmpty(referencingComponent.validationErrors)) {
+ registryState.hide();
+ } else {
+ updateValidationErrors(registryState,
referencingComponent);
+ }
+
+ // type
+ var registryType = $('<span
class="referencing-component-type"></span>').text(nfCommon.substringAfterLast(referencingComponent.type,
'.'));
+
+ // active thread count
+ var registryActiveThreadCount = $('<span
class="referencing-component-active-thread-count"></span>').addClass(referencingComponent.id
+ '-active-threads');
+ if
(nfCommon.isDefinedAndNotNull(referencingComponent.activeThreadCount) &&
referencingComponent.activeThreadCount > 0) {
+ registryActiveThreadCount.text('(' +
referencingComponent.activeThreadCount + ')');
+ }
+
+ // registry item
+ var registryItem =
$('<li></li>').append(registryState).append(registryLink).append(registryType).append(registryActiveThreadCount);
+ tasks.append(registryItem);
Review Comment:
These registry clients are being added to the Reporting Tasks section.
Please create a dedicated section for Flow Registry Clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
