Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1219#discussion_r88010937
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/InstanceClassLoader.java
---
@@ -88,7 +89,7 @@ public synchronized void setInstanceResources(final URL[]
urls) {
if (shimClassLoader != null) {
try {
c = shimClassLoader.loadClass(name, resolve);
- } catch (ClassNotFoundException cnf) {
+ } catch (NoClassDefFoundError | ClassNotFoundException e) {
--- End diff --
_NoClassDefFoundError_ is a runtime error (not checked exception) so why
are we giving it a special treatment here? I am not saying we should not be
handling runtime errors if there is a reason, just curious what that reason is
here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
