Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1219#discussion_r88032664
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java
---
@@ -746,8 +746,11 @@ public void run() {
removeConnection(conn);
}
- ExtensionManager.removeInstanceClassLoaderIfExists(id);
LOG.info("{} removed from flow", processor);
+
+ // this must be called after the logging statement b/c the
toString of processor calls NarCloseable
+ // and ends up using the InstanceClassLoader
+ ExtensionManager.removeInstanceClassLoaderIfExists(id);
--- End diff --
I think this gets kind of tricky, putting it in the finally block it would
get called even if the remove failed at the very beginning which might not be
what we want
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
