[ 
https://issues.apache.org/jira/browse/NIFI-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667083#comment-15667083
 ] 

ASF GitHub Bot commented on NIFI-3003:
--------------------------------------

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1219#discussion_r88010937
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/InstanceClassLoader.java
 ---
    @@ -88,7 +89,7 @@ public synchronized void setInstanceResources(final URL[] 
urls) {
             if (shimClassLoader != null) {
                 try {
                     c = shimClassLoader.loadClass(name, resolve);
    -            } catch (ClassNotFoundException cnf) {
    +            } catch (NoClassDefFoundError | ClassNotFoundException e) {
    --- End diff --
    
    _NoClassDefFoundError_ is a runtime error (not checked exception) so why 
are we giving it a special treatment here? I am not saying we should not be 
handling runtime errors if there is a reason, just curious what that reason is 
here.



> Move to Hadoop 2.7.x client libs
> --------------------------------
>
>                 Key: NIFI-3003
>                 URL: https://issues.apache.org/jira/browse/NIFI-3003
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> We should upgrade the Hadoop libraries NAR to use the Hadoop 2.7.x client 
> libs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to