[ 
https://issues.apache.org/jira/browse/NIFI-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667365#comment-15667365
 ] 

ASF GitHub Bot commented on NIFI-3003:
--------------------------------------

Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1219#discussion_r88032664
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java
 ---
    @@ -746,8 +746,11 @@ public void run() {
                     removeConnection(conn);
                 }
     
    -            ExtensionManager.removeInstanceClassLoaderIfExists(id);
                 LOG.info("{} removed from flow", processor);
    +
    +            // this must be called after the logging statement b/c the 
toString of processor calls NarCloseable
    +            // and ends up using the InstanceClassLoader
    +            ExtensionManager.removeInstanceClassLoaderIfExists(id);
    --- End diff --
    
    I think this gets kind of tricky, putting it in the finally block it would 
get called even if the remove failed at the very beginning which might not be 
what we want


> Move to Hadoop 2.7.x client libs
> --------------------------------
>
>                 Key: NIFI-3003
>                 URL: https://issues.apache.org/jira/browse/NIFI-3003
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> We should upgrade the Hadoop libraries NAR to use the Hadoop 2.7.x client 
> libs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to