adamdebreceni commented on code in PR #1391:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r979881572
##########
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp:
##########
@@ -53,26 +56,21 @@ TEST_CASE("Connections components are parsed from yaml",
"[YamlConfiguration]")
"- something_else\n" };
expectations = { { "success", "" }, { "failure", "" }, {
"something_else", "" } };
}
- YAML::Node connection_node = YAML::Load(serialized_yaml);
- YamlConnectionParser yaml_connection_parser(connection_node, "test_node",
parent_ptr, logger);
-
yaml_connection_parser.configureConnectionSourceRelationshipsFromYaml(*connection);
+ YAML::Node yaml_node = YAML::Load(serialized_yaml);
+ flow::Node connection_node{std::make_shared<YamlNode>(yaml_node)};
+ StructuredConnectionParser yaml_connection_parser(connection_node,
"test_node", parent_ptr, logger);
+ yaml_connection_parser.configureConnectionSourceRelationships(*connection);
const std::set<core::Relationship>& relationships =
connection->getRelationships();
REQUIRE(expectations == relationships);
}
SECTION("Queue size limits are read") {
- YAML::Node connection_node = YAML::Load(std::string {
+ YAML::Node yaml_node = YAML::Load(std::string {
"max work queue size: 231\n"
"max work queue data size: 12 MB\n" });
YamlConnectionParser yaml_connection_parser(connection_node, "test_node",
parent_ptr, logger);
REQUIRE(231 == yaml_connection_parser.getWorkQueueSizeFromYaml());
REQUIRE(12582912 ==
yaml_connection_parser.getWorkQueueDataSizeFromYaml()); // 12 * 1024 * 1024 B
}
- SECTION("Queue swap threshold is read") {
- YAML::Node connection_node = YAML::Load(std::string {
- "swap threshold: 231\n" });
- YamlConnectionParser yaml_connection_parser(connection_node, "test_node",
parent_ptr, logger);
- REQUIRE(231 == yaml_connection_parser.getSwapThresholdFromYaml());
- }
Review Comment:
rebase accident, readded it
##########
libminifi/src/core/flow/StructuredConnectionParser.cpp:
##########
@@ -108,20 +117,20 @@ uint64_t YamlConnectionParser::getSwapThresholdFromYaml()
const {
return 0;
Review Comment:
changed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
