adamdebreceni commented on code in PR #1391: URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r979884544
########## libminifi/include/core/flow/README.md: ########## @@ -0,0 +1,57 @@ +## Differences between JSON and YAML implementation + +### YAML + +The possible types of a `YAML::Node` are: +* Undefined +* Null +* Map +* Sequence +* Scalar + +#### Undefined + +The result of querying any member of `Null`, querying non-existing members of `Map`, +or non-existing indices of `Sequence`. + +Note that for `Map`s string conversion applies `map[0]` could be valid, given a key `"0"`, +while for `Sequence`s string index parsing does NOT happen `seq["0"]` +will return `Undefined` even if the sequence is non-empty. + +Querying or otherwise accessing an `Undefined` (other than `operator bool` or `IsDefined`) usually throws. Review Comment: the `operator bool()` is implemented as `IsDefined()`, so I replaced all `IsDefined()` calls with `operator bool()` calls, this part here describes the workings of the `YAML::Node`, I did not plan on exposing an `IsDefined`-like method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
