markap14 commented on PR #6433: URL: https://github.com/apache/nifi/pull/6433#issuecomment-1258290052
Thanks for all the work you've done here @simonbence! This is a huge changeset and really great work put together here. I did quite a lot of testing: - Basics of adding a registry, starting version control, stopping version control, changing version, view local modifications, revert changes. - Built flow that use registry using 1.16, then moved that flow into a nifi built on this branch, in order to simulate an upgrade form an older version of NiFi - Built flow that uses embedded versioned flows - Built flow that uses embedded versioned flow in 1.16 and copied over to instance from this branch - Tried to remove a registry client that was in use, which correctly failed - Verified dirty / up-to-date / conflict / new version available states - Tested standalone and clustered - Tested flows with embedded PG's that are not themselves versioned All seems to check out with the current build. +1 will merge to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
