adamdebreceni commented on code in PR #1391: URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r982151109
########## libminifi/include/core/json/JsonConfiguration.h: ########## @@ -0,0 +1,71 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <unordered_set> + +#include "core/FlowConfiguration.h" +#include "core/logging/LoggerConfiguration.h" +#include "core/ProcessorConfig.h" +#include "Exception.h" +#include "io/StreamFactory.h" +#include "io/validation.h" +#include "sitetosite/SiteToSite.h" +#include "utils/Id.h" +#include "utils/StringUtils.h" +#include "utils/file/FileSystem.h" +#include "core/flow/StructuredConfiguration.h" + +class JsonConfigurationTestAccessor; + +namespace org::apache::nifi::minifi::core { + +class JsonConfiguration : public StructuredConfiguration { + public: + explicit JsonConfiguration(ConfigurationContext ctx); + + ~JsonConfiguration() override = default; + + /** + * Returns a shared pointer to a ProcessGroup object containing the Review Comment: removed the comment ########## libminifi/include/core/flow/StructuredConfiguration.h: ########## @@ -0,0 +1,234 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <unordered_set> + +#include "core/FlowConfiguration.h" +#include "core/logging/LoggerConfiguration.h" +#include "core/ProcessorConfig.h" +#include "Exception.h" +#include "io/StreamFactory.h" +#include "io/validation.h" +#include "sitetosite/SiteToSite.h" +#include "utils/Id.h" +#include "utils/StringUtils.h" +#include "utils/file/FileSystem.h" +#include "core/flow/Node.h" + +namespace org::apache::nifi::minifi::core { + +static constexpr char const* CONFIG_FLOW_CONTROLLER_KEY = "Flow Controller"; +static constexpr char const* CONFIG_PROCESSORS_KEY = "Processors"; +static constexpr char const* CONFIG_CONTROLLER_SERVICES_KEY = "Controller Services"; +static constexpr char const* CONFIG_REMOTE_PROCESS_GROUP_KEY = "Remote Processing Groups"; +static constexpr char const* CONFIG_REMOTE_PROCESS_GROUP_KEY_V3 = "Remote Process Groups"; +static constexpr char const* CONFIG_PROVENANCE_REPORT_KEY = "Provenance Reporting"; +static constexpr char const* CONFIG_FUNNELS_KEY = "Funnels"; + +#define CONFIGURATION_USE_REGEX + +// Disable regex in EL for incompatible compilers +#if __GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ < 9) +#undef CONFIGURATION_USE_REGEX +#endif Review Comment: removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
