nandorsoma commented on code in PR #6368: URL: https://github.com/apache/nifi/pull/6368#discussion_r982217966
########## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/PutIceberg.java: ########## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.iceberg; + +import com.google.common.collect.ImmutableList; +import org.apache.iceberg.FileFormat; +import org.apache.iceberg.RowDelta; +import org.apache.iceberg.Table; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.io.TaskWriter; +import org.apache.iceberg.io.WriteResult; +import org.apache.nifi.annotation.behavior.WritesAttribute; +import org.apache.nifi.annotation.behavior.WritesAttributes; +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.components.AllowableValue; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.context.PropertyContext; +import org.apache.nifi.flowfile.FlowFile; +import org.apache.nifi.processor.ProcessContext; +import org.apache.nifi.processor.ProcessSession; +import org.apache.nifi.processor.Relationship; +import org.apache.nifi.processor.exception.ProcessException; +import org.apache.nifi.processor.util.StandardValidators; +import org.apache.nifi.processors.iceberg.converter.IcebergRecordConverter; +import org.apache.nifi.processors.iceberg.writer.IcebergTaskWriterFactory; +import org.apache.nifi.serialization.RecordReader; +import org.apache.nifi.serialization.RecordReaderFactory; +import org.apache.nifi.serialization.record.Record; +import org.apache.nifi.services.iceberg.IcebergCatalogService; + +import java.io.InputStream; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Locale; +import java.util.Map; +import java.util.Set; + +import static org.apache.iceberg.TableProperties.DEFAULT_FILE_FORMAT; +import static org.apache.iceberg.TableProperties.DEFAULT_FILE_FORMAT_DEFAULT; + +@Tags({"iceberg", "put", "table", "store", "record", "parse", "orc", "parquet", "avro"}) +@CapabilityDescription("This processor uses Iceberg API to parse and load records into Iceberg tables. " + + "The incoming data sets are parsed with Record Reader Controller Service and ingested into an Iceberg table using the configured catalog service and provided table information. " + + "It is important that the incoming records and the Iceberg table must have matching schemas and the target Iceberg table should already exist. " + + "To avoid 'small file problem' it is recommended pre-appending a MergeRecord processor.") +@WritesAttributes({ + @WritesAttribute(attribute = "iceberg.record.count", description = "The number of records in the FlowFile.") +}) +public class PutIceberg extends AbstractIcebergProcessor { + + public static final String ICEBERG_RECORD_COUNT = "iceberg.record.count"; + + static final PropertyDescriptor RECORD_READER = new PropertyDescriptor.Builder() + .name("record-reader") + .displayName("Record Reader") + .description("Specifies the Controller Service to use for parsing incoming data and determining the data's schema.") + .identifiesControllerService(RecordReaderFactory.class) + .required(true) + .build(); + + static final PropertyDescriptor CATALOG_NAMESPACE = new PropertyDescriptor.Builder() + .name("catalog-namespace") + .displayName("Catalog Namespace") + .description("The namespace of the catalog.") + .required(true) + .addValidator(StandardValidators.NON_BLANK_VALIDATOR) + .build(); + + static final PropertyDescriptor TABLE_NAME = new PropertyDescriptor.Builder() + .name("table-name") + .displayName("Table Name") + .description("The name of the table.") + .required(true) + .addValidator(StandardValidators.NON_BLANK_VALIDATOR) + .build(); + + static final PropertyDescriptor FILE_FORMAT = new PropertyDescriptor.Builder() + .name("file-format") + .displayName("File Format") + .description("File format to use when writing Iceberg data files. If not set the 'write.format.default' table property will be used, default value is parquet.") + .allowableValues( + new AllowableValue("AVRO"), + new AllowableValue("PARQUET"), + new AllowableValue("ORC")) + .required(false) + .build(); + + static final PropertyDescriptor TARGET_FILE_SIZE = new PropertyDescriptor.Builder() + .name("target-file-size") + .displayName("Target File Size") + .description("Controls the size of files generated to target about this many bytes. If not set the 'write.target-file-size-bytes' table property will be used, default value is 512 MB.") + .addValidator(StandardValidators.LONG_VALIDATOR) + .required(false) + .build(); + + static final Relationship REL_SUCCESS = new Relationship.Builder() + .name("success") + .description("A FlowFile is routed to this relationship after the data ingestion was successful.") + .build(); + + static final Relationship REL_FAILURE = new Relationship.Builder() + .name("failure") + .description("A FlowFile is routed to this relationship if the data ingestion failed and retrying the operation will also fail, such as an invalid data or schema.") + .build(); + + private static final List<PropertyDescriptor> PROPERTIES = Collections.unmodifiableList(Arrays.asList( + RECORD_READER, + CATALOG, + CATALOG_NAMESPACE, + TABLE_NAME, + FILE_FORMAT, + TARGET_FILE_SIZE, + KERBEROS_USER_SERVICE + )); + + public static final Set<Relationship> RELATIONSHIPS = Collections.unmodifiableSet(new HashSet<>(Arrays.asList( + REL_SUCCESS, + REL_FAILURE + ))); + + @Override + protected List<PropertyDescriptor> getSupportedPropertyDescriptors() { + return PROPERTIES; + } + + @Override + public Set<Relationship> getRelationships() { + return RELATIONSHIPS; + } + + @Override + public void doOnTrigger(ProcessContext context, ProcessSession session) throws ProcessException { + FlowFile flowFile = session.get(); + if (flowFile == null) { + return; + } + + final RecordReaderFactory readerFactory = context.getProperty(RECORD_READER).asControllerService(RecordReaderFactory.class); + final String fileFormat = context.getProperty(FILE_FORMAT).evaluateAttributeExpressions().getValue(); + final String targetFileSize = context.getProperty(TARGET_FILE_SIZE).evaluateAttributeExpressions().getValue(); + + Table table; + + try { + table = loadTable(context); + } catch (Exception e) { + getLogger().error("Failed to load table from catalog", e); + session.transfer(flowFile, REL_FAILURE); + return; + } + + final FileFormat format = getFileFormat(table.properties(), fileFormat); Review Comment: What happens when this method throws an exception? In a more severe scenario (failed to load table), the flow file will be routed to failure. In this situation, a process exception will be thrown when this method is run as a privileged action, and if not, the original exception will penalize the processor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
