mark-bathori commented on code in PR #6368: URL: https://github.com/apache/nifi/pull/6368#discussion_r982309957
########## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/test/java/org/apache/nifi/processors/iceberg/TestPutIcebergWithHadoopCatalog.java: ########## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.iceberg; + +import org.apache.avro.Schema; +import org.apache.commons.io.IOUtils; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.Table; +import org.apache.iceberg.TableProperties; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.types.Types; +import org.apache.nifi.avro.AvroTypeUtil; +import org.apache.nifi.processors.iceberg.catalog.TestHadoopCatalogService; +import org.apache.nifi.reporting.InitializationException; +import org.apache.nifi.serialization.record.MockRecordParser; +import org.apache.nifi.serialization.record.RecordField; +import org.apache.nifi.serialization.record.RecordSchema; +import org.apache.nifi.util.MockFlowFile; +import org.apache.nifi.util.TestRunner; +import org.apache.nifi.util.TestRunners; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.ValueSource; + +import java.io.IOException; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.sql.Date; +import java.sql.Time; +import java.sql.Timestamp; +import java.util.Arrays; +import java.util.HashMap; +import java.util.Map; + +import static org.apache.nifi.processors.iceberg.PutIceberg.ICEBERG_RECORD_COUNT; +import static org.apache.nifi.processors.iceberg.util.IcebergTestUtils.validateNumberOfDataFiles; +import static org.apache.nifi.processors.iceberg.util.IcebergTestUtils.validatePartitionFolders; + +public class TestPutIcebergWithHadoopCatalog { + + private TestRunner runner; + private PutIceberg processor; + private Schema inputSchema; + + public static Namespace namespace = Namespace.of("test_metastore"); + + public static TableIdentifier tableIdentifier = TableIdentifier.of(namespace, "date"); + + public static org.apache.iceberg.Schema DATE_SCHEMA = new org.apache.iceberg.Schema( + Types.NestedField.required(1, "timeMicros", Types.TimeType.get()), + Types.NestedField.required(2, "timestampMicros", Types.TimestampType.withZone()), + Types.NestedField.required(3, "date", Types.DateType.get()) + ); + + @BeforeEach + public void setUp() throws Exception { + final String avroSchema = IOUtils.toString(Files.newInputStream(Paths.get("src/test/resources/date.avsc")), StandardCharsets.UTF_8); + inputSchema = new Schema.Parser().parse(avroSchema); + + processor = new PutIceberg(); + } + + private void initRecordReader() throws InitializationException { + MockRecordParser readerFactory = new MockRecordParser(); Review Comment: I removed every final keyword from the test classes except the static values to be consistent. Is that ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
