lordgamez commented on code in PR #1420: URL: https://github.com/apache/nifi-minifi-cpp/pull/1420#discussion_r1011743838
########## docker/test/integration/minifi/core/MinifiC2ServerSslContainer.py: ########## @@ -0,0 +1,36 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + + +from .Container import Container + + +class MinifiC2ServerSslContainer(Container): + def __init__(self, name, vols, network, image_store, command=None): + super().__init__(name, 'minifi-c2-server-ssl', vols, network, image_store, command) Review Comment: Good point, added an `ssl` contructor argument to figure out which version should be instantiated in fd13cbd5ad0819f5a3be0e01cbdb4cac5db3fadd (passing the engine as parameter is more risky as any engine could be passed not just a C2 server engine) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
