lordgamez commented on code in PR #1420:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1420#discussion_r1021751163
##########
docker/test/integration/minifi/core/ImageStore.py:
##########
@@ -105,6 +107,14 @@ def __build_minifi_cpp_image(self):
RUN echo
nifi.metrics.publisher.class=PrometheusMetricsPublisher >>
{minifi_root}/conf/minifi.properties
RUN echo
nifi.metrics.publisher.PrometheusMetricsPublisher.port=9936 >>
{minifi_root}/conf/minifi.properties
RUN echo
nifi.metrics.publisher.metrics=RepositoryMetrics,QueueMetrics,GetFileMetrics,GetTCPMetrics,FlowInformation,DeviceInfoNode
>> {minifi_root}/conf/minifi.properties
+ RUN echo nifi.c2.enable=true >>
{minifi_root}/conf/minifi.properties
Review Comment:
Well it would be possible, but that would require creating a separate minifi
image containing a different minifi.properties file and change the tests where
we want to use that image instead of the default minifi image. Now we already
have a provenance repo and https version besides this which is already too
many. A better solution would be to refactor the tests to have a single minifi
image and use the configuration file as a bind mount. Then the specific config
file could be set in the test description, but that change should be done in a
separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
