markobean commented on code in PR #6506:
URL: https://github.com/apache/nifi/pull/6506#discussion_r1014414545
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ControlRate.java:
##########
@@ -71,30 +70,57 @@ public class ControlRate extends AbstractProcessor {
public static final String DATA_RATE = "data rate";
Review Comment:
I believe this is a breaking change that would affect existing flows. At
least, when I updated the values to have a different case, e.g. "Data Rate",
all unit tests failed. I don't see a big deal with this, and to avoid potential
problems I think it should be left as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
