exceptionfactory commented on PR #6506: URL: https://github.com/apache/nifi/pull/6506#issuecomment-1309629082
Thanks for making the updates and noting the detail about the minimum validation setting @markobean, the changes look good. The new test method push the total test time to over 12 seconds for standard execution, which will place it among the slower unit tests, contributing to an overall slow build process. I have an idea for updating the unit test to extend ControlRate for the test class and implement an alternative current time method. With that background, I'm not opposed to moving forward with this PR, and I can evaluate an improvement in a subsequent Jira issue. I will defer to @thenatog for final review at this point, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
