ChrisSamo632 commented on code in PR #6544:
URL: https://github.com/apache/nifi/pull/6544#discussion_r1014600354
##########
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/GetElasticsearch.java:
##########
@@ -213,7 +273,7 @@ private void handleElasticsearchException(final
ElasticsearchException ese, Flow
getLogger().error(msg, ese);
if (input != null) {
session.penalize(input);
- input = session.putAttribute(input, "elasticsearch.get.error",
ese.getMessage());
+ session.putAttribute(input, "elasticsearch.get.error",
ese.getMessage());
Review Comment:
I was thinking that `input` wasn't then passed back out of the method and so
there was no need to re-assign it, but actually it's used in the subsequent
`session.transfer`, so agree this should be re-instated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
