ChrisSamo632 commented on code in PR #6544:
URL: https://github.com/apache/nifi/pull/6544#discussion_r1014600503
##########
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceImpl.java:
##########
@@ -416,6 +495,26 @@ public void refresh(final String index, final Map<String,
String> requestParamet
}
}
+ @Override
+ public boolean exists(final String index, final Map<String, String>
requestParameters) {
+ try {
+ final Response response = performRequest("HEAD", "/" + index,
requestParameters, null);
Review Comment:
I think this is a common thing throughout the methods in this class and was
wondering the same myself (but then forgot) - I'll make a general change to
ensure that a leading `/` is always present but that we don't end up with
duplicates (e.g. `host:port//index`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]