markap14 commented on code in PR #6638:
URL: https://github.com/apache/nifi/pull/6638#discussion_r1023238439
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/VersionedFlowSynchronizer.java:
##########
@@ -378,6 +378,7 @@ private void synchronizeFlow(final FlowController
controller, final DataFlow exi
if (versionedFlow != null) {
controller.setMaxTimerDrivenThreadCount(versionedFlow.getMaxTimerDrivenThreadCount());
+
controller.setMaxEventDrivenThreadCount(versionedFlow.getMaxTimerDrivenThreadCount());
Review Comment:
The `getMaxEventDrivenThreadCount()` also will default to `0`, though. So if
the flow.json.gz doesn't have that field (which will be everyone's when they
are upgrading) it will call `controller.setMaxEventDrivenThreadCount(0)` which
will throw an `IllegalArgumentException`. So need to either default the value
to `1` or check if it's set before calling this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
