markobean commented on code in PR #6638:
URL: https://github.com/apache/nifi/pull/6638#discussion_r1023357713
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/VersionedFlowSynchronizer.java:
##########
@@ -378,6 +378,7 @@ private void synchronizeFlow(final FlowController
controller, final DataFlow exi
if (versionedFlow != null) {
controller.setMaxTimerDrivenThreadCount(versionedFlow.getMaxTimerDrivenThreadCount());
+
controller.setMaxEventDrivenThreadCount(versionedFlow.getMaxTimerDrivenThreadCount());
Review Comment:
It does feel a little hacky. If you don't set the value to 1 when declaring
the variable, the default value of an int is 0. So you could use this in
VersionedDataflow.java (line 58)
```
public int getMaxEventDrivenThreadCount() {
return maxEventDrivenThreadCount < 1 ? 1 : maxEventDrivenThreadCount;
}
}
```
Or even better:
```
public int getMaxEventDrivenThreadCount() {
return maxEventDrivenThreadCount < 1 ?
DEFAULT_MAX_EVENT_DRIVEN_THREAD_COUNT : maxEventDrivenThreadCount;
}
```
.. and setup the proper `private static final` constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
