fgerlits commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044659717
##########
libminifi/test/rocksdb-tests/EncryptionTests.cpp:
##########
@@ -77,8 +75,8 @@ TEST_CASE_METHOD(FFRepoFixture, "FlowFileRepository creates
checkpoint and loads
// pass
}
SECTION("With encryption") {
- utils::file::FileUtils::create_dir((home_ / "conf").str());
- std::ofstream{(home_ / "conf" / "bootstrap.conf").str()}
+ utils::file::FileUtils::create_dir((home_ / "conf"));
+ std::ofstream{(home_ / "conf" / "bootstrap.conf")}
Review Comment:
the double parens in line 78 are still there; are those needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]