fgerlits commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044660504
##########
libminifi/test/rocksdb-tests/RocksDBTests.cpp:
##########
@@ -232,9 +231,9 @@ void
withDefaultEnv(minifi::internal::Writable<rocksdb::DBOptions>& db_opts) {
}
TEST_CASE_METHOD(RocksDBTest, "Error is logged if different encryption keys
are used", "[rocksDBTest10]") {
- utils::Path home_dir{createTempDirectory()};
- utils::file::FileUtils::create_dir((home_dir / "conf").str());
- std::ofstream{(home_dir / "conf" / "bootstrap.conf").str()}
+ auto home_dir = createTempDirectory();
+ utils::file::FileUtils::create_dir((home_dir / "conf"));
+ std::ofstream{(home_dir / "conf" / "bootstrap.conf")}
Review Comment:
same here; line 235 still has the double parens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
