exceptionfactory commented on code in PR #6791:
URL: https://github.com/apache/nifi/pull/6791#discussion_r1052607445
##########
nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java:
##########
@@ -433,7 +434,7 @@ public class CaptureChangeMySQL extends
AbstractSessionFactoryProcessor {
private BinlogLifecycleListener lifecycleListener;
private GtidSet gtidSet;
- private final LinkedBlockingQueue<RawBinlogEvent> queue = new
LinkedBlockingQueue<>();
+ private final BlockingQueue<RawBinlogEvent> queue = new
LinkedBlockingQueue<>(100);
Review Comment:
Is there a particular reason for selecting `100` as the queue size? Initial
sets of change events could number in the thousands, but on the other hand,
keeping this low avoids memory consumption issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
