exceptionfactory commented on code in PR #6791:
URL: https://github.com/apache/nifi/pull/6791#discussion_r1055922009
##########
nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java:
##########
@@ -433,7 +434,7 @@ public class CaptureChangeMySQL extends
AbstractSessionFactoryProcessor {
private BinlogLifecycleListener lifecycleListener;
private GtidSet gtidSet;
- private final LinkedBlockingQueue<RawBinlogEvent> queue = new
LinkedBlockingQueue<>();
+ private final BlockingQueue<RawBinlogEvent> queue = new
LinkedBlockingQueue<>(100);
Review Comment:
A large number of events can build up depending on the initial starting
position in the binary log, or lots of activity. The value of `100` may still
be best to avoid memory consumption, but I would have to take a closer look at
the polling behavior to see whether there is value in a larger buffer to handle
this kind of scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
