fgerlits commented on code in PR #1486:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1486#discussion_r1066898317
##########
extensions/coap/server/CoapServer.h:
##########
@@ -183,7 +183,7 @@ class CoapServer : public core::Connectable {
/**
* Determines if we are connected and operating
*/
- virtual bool isRunning() {
+ virtual bool isRunning() const {
Review Comment:
I think this should be `override` instead of `virtual`
##########
extensions/libarchive/FocusArchiveEntry.h:
##########
@@ -64,7 +64,7 @@ class FocusArchiveEntry : public core::Processor {
public:
explicit ReadCallback(core::Processor*, utils::file::FileManager
*file_man, ArchiveMetadata *archiveMetadata);
int64_t operator()(const std::shared_ptr<io::InputStream>& stream) const;
- bool isRunning() {return proc_->isRunning();}
+ bool isRunning() const {return proc_->isRunning();}
Review Comment:
should this be marked `override`, as well?
##########
libminifi/include/c2/C2Protocol.h:
##########
@@ -75,7 +75,7 @@ class C2Protocol : public core::Connectable {
/**
* Determines if we are connected and operating
*/
- virtual bool isRunning() {
+ virtual bool isRunning() const {
Review Comment:
`virtual` -> `override`
##########
libminifi/include/controllers/ThreadManagementService.h:
##########
@@ -91,7 +91,7 @@ class ThreadManagementService : public
core::controller::ControllerService {
void yield() {
}
- bool isRunning() {
+ bool isRunning() const {
Review Comment:
I think this should be marked `override`, as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
