lordgamez commented on code in PR #1486:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1486#discussion_r1067070133
##########
extensions/libarchive/FocusArchiveEntry.h:
##########
@@ -64,7 +64,7 @@ class FocusArchiveEntry : public core::Processor {
public:
explicit ReadCallback(core::Processor*, utils::file::FileManager
*file_man, ArchiveMetadata *archiveMetadata);
int64_t operator()(const std::shared_ptr<io::InputStream>& stream) const;
- bool isRunning() {return proc_->isRunning();}
+ bool isRunning() const {return proc_->isRunning();}
Review Comment:
This method was unused so I removed it in
a20c3a130d80bd73e4383b8161e23c52c77fb1fd
##########
extensions/coap/server/CoapServer.h:
##########
@@ -183,7 +183,7 @@ class CoapServer : public core::Connectable {
/**
* Determines if we are connected and operating
*/
- virtual bool isRunning() {
+ virtual bool isRunning() const {
Review Comment:
Updated in a20c3a130d80bd73e4383b8161e23c52c77fb1fd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
